[webkit-reviews] review granted: [Bug 83172] Switch web intents API to be vendor-prefixed : [Attachment 135733] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Greg Billock <gbillock at google.com>'s
request for review:
Bug 83172: Switch web intents API to be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=83172

Attachment 135733: Patch
https://bugs.webkit.org/attachment.cgi?id=135733&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135733&action=review


> Source/WebCore/Modules/intents/NavigatorIntents.idl:28
> -	   void startActivity(in Intent intent,
> -			      in [Callback, Optional] IntentResultCallback
successCallback,
> -			      in [Callback, Optional] IntentResultCallback
failureCallback)
> +	   void webkitStartActivity(in Intent intent,
> +				    in [Callback, Optional]
IntentResultCallback successCallback,
> +				    in [Callback, Optional]
IntentResultCallback failureCallback)

Your patch follows the traditional style of naming the implementation of
vendor-prefixed functions with the vendor prefix, but one thing we've been
discussing is whether to use
<https://trac.webkit.org/wiki/WebKitIDL#ImplementedAs> to keep the
vendor-prefixed names in IDL and use unprefixed names in the implementation.