[webkit-reviews] review requested: [Bug 83227] [chromium] wrong justification for arabic/persian page in cr-win : [Attachment 135716] patch w/ layout test

[bugzilla-daemon at webkit.org]

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 83227: [chromium] wrong justification for arabic/persian page in cr-win
https://bugs.webkit.org/show_bug.cgi?id=83227

Attachment 135716: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=135716&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
the patch mostly matches justify in WebKit's
UniscribeController::shapeAndPlaceItem.

But there are 2 things that I do not understand:
1. justify() is called per run, I think. Then, inside justify(), can we work
justification on m_runs?, they should not be the same unless m_runs.size()
always equals to 1. But the rendered results looks ok on the page I tested. I
need to look into further.
2. in UniscribeController::shapeAndPlaceItem, the mapping of spaceCharacter is
assigned as:
spaceCharacters[clusters[k]] = m_currentCharacter + k + item.iCharPos;
I do not understand why it is not "spaceCharacters[clusters[k]] = k +
item.iCharPos;"