[webkit-reviews] review granted: [Bug 83138] DOM measurement APIs should operate on pixel snapped values. : [Attachment 135550] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 83138: DOM measurement APIs should operate on pixel snapped values.
https://bugs.webkit.org/show_bug.cgi?id=83138

Attachment 135550: Patch
https://bugs.webkit.org/attachment.cgi?id=135550&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135550&action=review


> Source/WebCore/dom/Element.cpp:351
>      if (RenderBoxModelObject* rend = renderBoxModelObject())

Let's remove those abreviations (not repeated on all the other changes) while
at it: renderBoxModelObject would be my favorite but at least renderer would be
OK.

(note that also most of this logic could use const RenderObject's but that's
another - definitely bug-worthy - story)