[webkit-reviews] review granted: [Bug 83080] Foreground of apple.com/iphone video page visible during full screen animation. : [Attachment 135456] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 4 13:21:20 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 83080: Foreground of apple.com/iphone video page visible during full screen
animation.
https://bugs.webkit.org/show_bug.cgi?id=83080

Attachment 135456: Patch
https://bugs.webkit.org/attachment.cgi?id=135456&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
Here we go whack-a-moling. You should look at
CSSStyleSelector::adjustRenderStyle() for the other ones you need,
specifically:

    if (style->hasAutoZIndex() && ((e && e->document()->documentElement() == e)
|| style->opacity() < 1.0f
	|| style->hasTransformRelatedProperty() || style->hasMask() ||
style->boxReflect() || style->hasFilter()

    bool hasTransformRelatedProperty() const { return hasTransform() ||
preserves3D() || hasPerspective(); }


More information about the webkit-reviews mailing list