[webkit-reviews] review granted: [Bug 80134] [CSSRegions]Implement NamedFlow::contentNodes attribute : [Attachment 133747] Patch 4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 4 12:25:31 PDT 2012
Dave Hyatt <hyatt at apple.com> has granted Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 80134: [CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134
Attachment 133747: Patch 4
https://bugs.webkit.org/attachment.cgi?id=133747&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133747&action=review
r=me
> Source/WebCore/rendering/RenderFlowThread.h:167
> + NamedFlowContentNodes m_contentNodes;
> +
> AtomicString m_flowThread;
> RenderRegionList m_regionList;
This isn't really something you should do for this patch, but going forward I
think we might want to pull all the flow thread stuff in RenderView into a
helper class.
More information about the webkit-reviews
mailing list