[webkit-reviews] review granted: [Bug 83167] MediaStream API: Deleting the chromium bridge class MediaStreamCenterInternal : [Attachment 135600] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 4 10:50:55 PDT 2012


Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 83167: MediaStream API: Deleting the chromium bridge class
MediaStreamCenterInternal
https://bugs.webkit.org/show_bug.cgi?id=83167

Attachment 135600: Patch
https://bugs.webkit.org/attachment.cgi?id=135600&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135600&action=review


> Source/WebCore/ChangeLog:8
> +	   No actual code changes.

I might say "no behavior changes" rather than no "code" changes.  There are
code changes.  :)

> Source/WebCore/platform/mediastream/chromium/MediaStreamCenterChromium.h:38
> +#include <public/WebMediaStreamCenterClient.h>

This will be the first time we've put a header like this into a header, but I
think it should work as long as no one outside of WebCore/platform ever
includes this header directly.	Given the way you've set things up, that seems
like it should be the case.


More information about the webkit-reviews mailing list