[webkit-reviews] review denied: [Bug 78746] Add identifying methods for date/time input types. : [Attachment 135580] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 4 10:31:59 PDT 2012


Adam Barth <abarth at webkit.org> has denied Oli Lan <olilan at chromium.org>'s
request for review:
Bug 78746: Add identifying methods for date/time input types.
https://bugs.webkit.org/show_bug.cgi?id=78746

Attachment 135580: Patch
https://bugs.webkit.org/attachment.cgi?id=135580&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135580&action=review


Thanks for the patch.  One process comment and one substantive comment below:

>> Source/WebCore/ChangeLog:8
>> +	    No new tests. (OOPS!)
> 
> You should remove the 'No new tests' and either add and list tests, or
explain why no new tests were possible.  [changelog/nonewtests] [5]

Please also add some information to the ChangeLog about why you're making this
change.  The purpose of the ChangeLog is to communicate with the rest of the
community about your change.  A blank ChangeLog like this one doesn't
communicate much...

> Source/WebKit/chromium/public/WebTextInputType.h:56
> +    WebTextInputTypeDate,
> +    WebTextInputTypeDateTime,
> +    WebTextInputTypeDateTimeLocal,
> +    WebTextInputTypeMonth,
> +    WebTextInputTypeTime,
> +    WebTextInputTypeWeek,

Can we add an API test to make sure these are working correctly? 
http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/tests


More information about the webkit-reviews mailing list