[webkit-reviews] review denied: [Bug 83172] Switch web intents API to be vendor-prefixed : [Attachment 135612] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Greg Billock
<gbillock at google.com>'s request for review:
Bug 83172: Switch web intents API to be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=83172

Attachment 135612: Patch
https://bugs.webkit.org/attachment.cgi?id=135612&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135612&action=review


> Source/WebCore/Modules/intents/DOMWindowIntents.idl:33
> +	   attribute IntentConstructor webkitIntent;

nit: should be WebKitIntent

note the case.	constructors should start with an upper case letter.

> LayoutTests/webintents/resources/web-intents-testing.js:21
> +  navigator.webkitStartActivity(new webkitIntent("action1", "mime/type1",
"test"), onSuccess, onFailure);

webkitIntent -> WebKitIntent