[webkit-reviews] review granted: [Bug 83164] Add WTF::getCurrentLocalTime() : [Attachment 135593] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 4 09:51:07 PDT 2012

Alexey Proskuryakov <ap at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 83164: Add WTF::getCurrentLocalTime()

Attachment 135593: Patch

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135593&action=review

> Source/WTF/ChangeLog:13
> +	   (WTF):

Please always remove useless gunk like this.

> Source/WTF/wtf/CurrentTime.h:61
> +inline void getCurrentLocalTime(struct tm* localTM)

Why does this need to be inline? It most likely shouldn't be.

> Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp:148
> +    String dateString = makeRFC2822DateString(localTM.tm_wday,
localTM.tm_mday, localTM.tm_mon, 1900 + localTM.tm_year, localTM.tm_hour,
localTM.tm_min, localTM.tm_sec, calculateUTCOffset() / (1000 * 60));

It's not great that conversion to local time and time zone offset calculation
are separate steps, subject to race condition. But not new to this patch, and
not very likely to occur in practice.

More information about the webkit-reviews mailing list