[webkit-reviews] review granted: [Bug 83162] Web Inspector: migrate from InspectorFrontendHost.saveAs to InspectorFrontendHost.save. : [Attachment 135592] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 4 08:28:46 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 83162: Web Inspector: migrate from InspectorFrontendHost.saveAs to
InspectorFrontendHost.save.
https://bugs.webkit.org/show_bug.cgi?id=83162

Attachment 135592: Patch
https://bugs.webkit.org/attachment.cgi?id=135592&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135592&action=review


> Source/WebCore/ChangeLog:8
> +	   This change adds Save item into the context manus for inspector. It
also makes

typo: manus -> menus

> Source/WebCore/inspector/InspectorFrontendClient.h:63
> +    virtual void save(const WTF::String& url, const WTF::String& content,
bool saveAs) = 0;

saveAs -> forceSaveAs


More information about the webkit-reviews mailing list