[webkit-reviews] review granted: [Bug 83033] [Qt][WK2] Make the WebView a subclass of Flickable : [Attachment 135554] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 4 05:13:13 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 83033: [Qt][WK2] Make the WebView a subclass of Flickable
https://bugs.webkit.org/show_bug.cgi?id=83033

Attachment 135554: proposed patch
https://bugs.webkit.org/attachment.cgi?id=135554&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135554&action=review


>>> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1410
>>> +}
>> 
>> so from the InteractionEngine you call this (handleFlickableMousePress)
>> 
>> How is that different that
>> 
>> InteractionEngine::... {
>>     QMouseEvent mouseEvent(QEvent::MouseButtonPress, position,
Qt::LeftButton, Qt::NoButton, Qt::NoModifier);
>>     mouseEvent.setTimestamp(eventTimestampMillis);
>>     m_viewport->mousePressEvent(&mouseEvent);
>> }
>> 
>> ?
> 
> m_viewport->mousePressEvent(&mouseEvent) will send the event to the web
process, and _not_ to the Flickable.
> That is the whole point of the subclassing.

qobject_cast<QQuickFlickable>(m_viewport)->mousePressEvent(&mouseEvent) ?


More information about the webkit-reviews mailing list