[webkit-reviews] review granted: [Bug 82192] [EFL][DRT] Catch the "resource, request, willsend" signal : [Attachment 135315] Proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 82192: [EFL][DRT] Catch the "resource,request,willsend" signal
https://bugs.webkit.org/show_bug.cgi?id=82192

Attachment 135315: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=135315&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135315&action=review


cq- because of the comments

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:169
> +    // the main frame, a sub-frame, or the sub-objects in that document (via
Chromium).

I know this line was still here, but via Chromium here means what? you are
doing the same chromium does? or the author misspelled Chrome(Client)?

> Source/WebKit/efl/ewk/ewk_frame.h:110
> +    Eina_Bool is_main_frame_request; /** < indicates is the request is for
the main frame */

is the request -> if the request