[webkit-reviews] review granted: [Bug 83140] Implement animatedPathSegList support for SVGPathElement : [Attachment 135552] Patch

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 83140: Implement animatedPathSegList support for SVGPathElement
https://bugs.webkit.org/show_bug.cgi?id=83140

Attachment 135552: Patch
https://bugs.webkit.org/attachment.cgi?id=135552&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
Well done! r=me with a few comments:

View in context: https://bugs.webkit.org/attachment.cgi?id=135552&action=review


> Source/WebCore/ChangeLog:8
> +	   Add last missing piece of animVal support: animations of the
SVGPathElement's 'd' attribute

Add the last

> Source/WebCore/svg/SVGAnimatedType.cpp:441
> +    // AnimatedColor is only used for CSS property animations.
> +    if (type == AnimatedUnknown || type == AnimatedColor)
>	   return false;
> -    }
> -
> -    ASSERT_NOT_REACHED();
> -    return false;
> +    return true;

What about: return (type != AnimatedUnknown && type != AnimatedColor);

> Source/WebCore/svg/SVGAnimatedTypeAnimator.h:43
> +    virtual PassOwnPtr<SVGAnimatedType> startAnimValAnimation(const
Vector<SVGAnimatedProperty*>&) = 0;
> +    virtual void stopAnimValAnimation(const Vector<SVGAnimatedProperty*>&) =
0;
> +    virtual void resetAnimValToBaseVal(const Vector<SVGAnimatedProperty*>&,
SVGAnimatedType*) = 0;
> +    virtual void animValWillChange(const Vector<SVGAnimatedProperty*>&) = 0;

> +    virtual void animValDidChange(const Vector<SVGAnimatedProperty*>&) = 0;

Really happy to see them as pure virtual finally!