[webkit-reviews] review granted: [Bug 75523] Unify and modernize fast/css/{outline, background}-currentcolor.html : [Attachment 135513] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Barr
<davidbarr at chromium.org>'s request for review:
Bug 75523: Unify and modernize fast/css/{outline,background}-currentcolor.html
https://bugs.webkit.org/show_bug.cgi?id=75523

Attachment 135513: Patch
https://bugs.webkit.org/attachment.cgi?id=135513&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135513&action=review


> LayoutTests/ChangeLog:10
> +	   Reviewed by NOBODY (OOPS!).

Nit: The Reviewed by line should be after the bug URL.

> LayoutTests/fast/css/background-currentcolor.html:9
> +  <div id="test1" style="color:green; background: currentColor"/>
> +  <div id="test2" style="color:red; background: currentColor"/>
>    <div style="color:green">
> -    <div id="three" style="color:currentColor; background: currentColor"
></div>
> +    <div id="test3" style="color:currentColor; background: currentColor"/>

This HTML5 markup is invalid as a <div> doesn't self-close. That is, you must
explicitly specify a </div>.

> LayoutTests/fast/css/outline-currentcolor.html:9
> +  <div id="test1" id="one" style="color:green; outline: solid 1em
currentColor"/>
> +  <div id="test2" id="two" style="color:red; outline: solid 1em
currentColor"/>
>    <div style="color:green">
> -    <div id="three" style="color:currentColor; outline: solid 1em
currentColor" ></div>
> +    <div id="test3" style="color:currentColor; outline: solid 1em
currentColor"/>

Ditto.