[webkit-reviews] review denied: [Bug 83106] Call histogramEnumeration directly : [Attachment 135488] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 83106: Call histogramEnumeration directly
https://bugs.webkit.org/show_bug.cgi?id=83106

Attachment 135488: Patch
https://bugs.webkit.org/attachment.cgi?id=135488&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135488&action=review


> Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:128
> -	   PlatformSupport::histogramEnumeration(name, sample, boundaryValue);
> +	   WebKit::Platform::current()->histogramEnumeration(name, sample,
boundaryValue);

This should use histogramEnumeration from HistogramSupport.h (because this file
is outside the platform directory).

> Source/WebCore/platform/chromium/PlatformSupport.h:-265
> -    static void histogramEnumeration(const char* name, int sample, int
boundaryValue);

Please remove the implementation of this function in PlatformSupport.cpp.