[webkit-reviews] review denied: [Bug 83109] Followup to "Call incrementStatsCounter directly" : [Attachment 135491] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 21:25:22 PDT 2012


Adam Barth <abarth at webkit.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 83109: Followup to "Call incrementStatsCounter directly"
https://bugs.webkit.org/show_bug.cgi?id=83109

Attachment 135491: Patch
https://bugs.webkit.org/attachment.cgi?id=135491&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Mark, you want to introduce an abstraction like
<http://trac.webkit.org/browser/trunk/Source/WebCore/platform/HistogramSupport.
h>, perhaps called StatsCounter.h.  We'll implement StatsCounterChromium.cpp
via WebKit::Platform and other ports can implement StatsCounterWhatever.cpp
however they like (if they want stats counting.


More information about the webkit-reviews mailing list