[webkit-reviews] review granted: [Bug 83115] Don't parse "show" and "hide" as valid values for display property. : [Attachment 135506] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 21:20:46 PDT 2012


Adam Barth <abarth at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 83115: Don't parse "show" and "hide" as valid values for display property.
https://bugs.webkit.org/show_bug.cgi?id=83115

Attachment 135506: Patch
https://bugs.webkit.org/attachment.cgi?id=135506&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch is obviously correct, but it seems like we could write some kind of
test, even if the test wouldn't do anything when CSS_GRID_LAYOUT was enabled. 
If I were writing this patch, I would include that test, but I can understand
why you didn't.


More information about the webkit-reviews mailing list