[webkit-reviews] review requested: [Bug 82986] jsr/sret should be removed : [Attachment 135495] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 3 20:13:26 PDT 2012
Filip Pizlo <fpizlo at apple.com> has asked for review:
Bug 82986: jsr/sret should be removed
https://bugs.webkit.org/show_bug.cgi?id=82986
Attachment 135495: the patch
https://bugs.webkit.org/attachment.cgi?id=135495&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
The previous patch failed to save/restore the correct state for finally
inlining. For example:
try {
switch (foo) {
case blah:
return bar;
}
} finally {
break;
}
Since the finally block was emitted inline in the return, the break would break
us out of the switch.
Other similarly horrible things would happen with scope depth and the finally
depth, etc.
More information about the webkit-reviews
mailing list