[webkit-reviews] review denied: [Bug 82091] [chromium] rename some functions in LayerRendererChromium to avoid ambiguity of the word clear : [Attachment 135377] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 14:45:50 PDT 2012


James Robinson <jamesr at chromium.org> has denied Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 82091: [chromium] rename some functions in LayerRendererChromium to avoid
ambiguity of the word clear
https://bugs.webkit.org/show_bug.cgi?id=82091

Attachment 135377: Patch
https://bugs.webkit.org/attachment.cgi?id=135377&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
These functions have the same name, but they're in very different types so I'm
not sure there is much risk of confusion.  I think clearFoo() is fairly well
established for clearing an m_foo pointer.

I think a better way to disambiguate LayerRendererChromium would be to move
this function up to CCLayerTreeHostImpl, where it would fit better


More information about the webkit-reviews mailing list