[webkit-reviews] review granted: [Bug 83017] Switch baseline values to LayoutUnits in RenderTableSection. : [Attachment 135312] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 14:08:16 PDT 2012


Julien Chaffraix <jchaffraix at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 83017: Switch baseline values to LayoutUnits in RenderTableSection.
https://bugs.webkit.org/show_bug.cgi?id=83017

Attachment 135312: Patch
https://bugs.webkit.org/attachment.cgi?id=135312&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135312&action=review


> Source/WebCore/rendering/RenderTableSection.cpp:391
> +	       m_rowPos[r + 1] = max<int>(m_rowPos[r + 1], m_grid[r].baseline +
baselineDescent);

It looks unfortunate that m_rowPos is actually using an integer here.


More information about the webkit-reviews mailing list