[webkit-reviews] review granted: [Bug 83057] [v8] Fix memory leak in V8LazyEventListener : [Attachment 135395] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 83057: [v8] Fix memory leak in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=83057

Attachment 135395: Patch
https://bugs.webkit.org/attachment.cgi?id=135395&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135395&action=review


> Source/WebCore/bindings/v8/V8LazyEventListener.cpp:217
> +    // Since we only parse once, there's no need to keep data used for
parsing around anymore.
> +    m_functionName = String();
> +    m_code = String();
> +    m_eventParameterName = String();
> +    m_sourceURL = String();

Nice change. Deserves a mention in the changelog since it's not directly fixing
the memory leak.