[webkit-reviews] review granted: [Bug 83050] Animation related classes should use CSSPropertyID rather than integers when manipulating CSS property ids. : [Attachment 135383] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alexis Menard
(darktears) <alexis.menard at openbossa.org>'s request for review:
Bug 83050: Animation related classes should use CSSPropertyID rather than
integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83050

Attachment 135383: Patch
https://bugs.webkit.org/attachment.cgi?id=135383&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=135383&action=review


Nice change!

> Source/WebCore/platform/animation/Animation.h:184
> +    static CSSPropertyID initialAnimationProperty() { return
CSSPropertyInvalid; }

I don't know that it is worth having initialAnimationProperty() and friends.
This was copied from the RenderStyle pattern, but it's only used in one place.