[webkit-reviews] review granted: [Bug 82996] Chromium testers should extract builds instead of building on their own : [Attachment 135262] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 82996: Chromium testers should extract builds instead of building on their
own
https://bugs.webkit.org/show_bug.cgi?id=82996

Attachment 135262: Patch
https://bugs.webkit.org/attachment.cgi?id=135262&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135262&action=review


> Tools/BuildSlaveSupport/built-product-archive:219
> +    elif platform == 'chromium':
> +	   removeDirectoryIfExists(configurationBuildDirectory)
> +	   os.makedirs(configurationBuildDirectory)
> +	   return unzipArchive(configurationBuildDirectory, configuration)

This is the same as the qt, gtk, efl branch.  Can we merge them?  Would also be
nice to do the removeDir/makedirs before the if.