[webkit-reviews] review granted: [Bug 82680] [Chromium] Do not force draws if prepareToDraw() fails : [Attachment 135258] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 11:25:19 PDT 2012

James Robinson <jamesr at chromium.org> has granted Daniel Sievers
<sievers at chromium.org>'s request for review:
Bug 82680: [Chromium] Do not force draws if prepareToDraw() fails

Attachment 135258: Patch

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135258&action=review

Seems OK.  Going to R+, but please make sure Nat has a chance to take a look
before you land.

> Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:591
>	   m_readbackRequestOnImplThread->success =

if we couldn't actually do a readback, success should be false - right?

More information about the webkit-reviews mailing list