[webkit-reviews] review granted: [Bug 82680] [Chromium] Do not force draws if prepareToDraw() fails : [Attachment 135258] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Daniel Sievers
<sievers at chromium.org>'s request for review:
Bug 82680: [Chromium] Do not force draws if prepareToDraw() fails
https://bugs.webkit.org/show_bug.cgi?id=82680

Attachment 135258: Patch
https://bugs.webkit.org/attachment.cgi?id=135258&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135258&action=review


Seems OK.  Going to R+, but please make sure Nat has a chance to take a look
before you land.

> Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:591
>	   m_readbackRequestOnImplThread->success =
!m_layerTreeHostImpl->isContextLost();

if we couldn't actually do a readback, success should be false - right?