[webkit-reviews] review canceled: [Bug 82571] [chromium] Flip transition painting delayed with threaded animations : [Attachment 134939] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 10:11:52 PDT 2012

Dana Jansens <danakj at chromium.org> has canceled Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 82571: [chromium] Flip transition painting delayed with threaded animations

Attachment 134939: Patch

------- Additional Comments from Dana Jansens <danakj at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134939&action=review

>> Source/WebCore/ChangeLog:24
>> +	    were not used outside of the CCLTHCommon.cpp at all.
> Yay, that's really where it should be.  If it ever does need to be used
outside (again) we should just leave it in the cpp and expose some explicit
functions like we do for everything else.  Thank you!

Yep :)

>> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:154
>> +}
> No need to pass animatingTransformToScreen here.  You can just ask the layer.

Yes, this happens later in the function, thanks.

>> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:1033
>> +	// FIXME: when we fix this "root-layer special case" behavior in
CCLayerTreeHost, we will have to fix it here, too.
> I see this copied around in so many tests.  I don't even know what this means

That's true, I'll just remove it here.

More information about the webkit-reviews mailing list