[webkit-reviews] review denied: [Bug 82853] [GTK] Add filesystem API interface : [Attachment 135330] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 09:43:20 PDT 2012

Gustavo Noronha (kov) <gns at gnome.org> has denied ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 82853: [GTK] Add filesystem API interface

Attachment 135330: Patch

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135330&action=review

I am not sure I understand the rationale for creating these new classes? What
problem are we trying to solve here? I don't like these empty shells tbh, I'd
rather have implementation of stuff in the patches, it makes it way easier to
understand what's intended, what's being solved and so on.

> Source/WebCore/ChangeLog:24
> +	   * platform/gtk/AsyncFileSystemCallbacksGtk.cpp: Added. This is an
implement of AsyncFileSystemCallbacks.

implement -> implementation

More information about the webkit-reviews mailing list