[webkit-reviews] review granted: [Bug 82522] [Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed : [Attachment 134417] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 82522: [Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if
the actual layer information wasn't changed
https://bugs.webkit.org/show_bug.cgi?id=82522

Attachment 134417: Patch
https://bugs.webkit.org/attachment.cgi?id=134417&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134417&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:78
> +	   toWebGraphicsLayer(children()[i])->setShouldUpdateVisibleRect();

hasPendingVisibleRectChange?

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:439
> +    if (!m_modified)
> +	   return;

I would add a newline after each return statement