[webkit-reviews] review granted: [Bug 82368] CSS Exclusions polygon shape arguments should be comma separated : [Attachment 134913] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 02:03:16 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 82368: CSS Exclusions polygon shape arguments should be comma separated
https://bugs.webkit.org/show_bug.cgi?id=82368

Attachment 134913: Patch
https://bugs.webkit.org/attachment.cgi?id=134913&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134913&action=review


> Source/WebCore/css/CSSParser.cpp:4305
> +	   else if (commaOrNull->unit != CSSParserValue::Operator ||
commaOrNull->iValue != ',')

We should really extract an inline helper function for this.


More information about the webkit-reviews mailing list