[webkit-reviews] review granted: [Bug 83001] Introduce another file-to-array script : [Attachment 135280] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 23:59:38 PDT 2012

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 83001: Introduce another file-to-array script

Attachment 135280: Patch 

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135280&action=review

> Source/WebCore/ChangeLog:12
> +	   - No whitespace stripping for CSS files

Maybe we want to support an option to strip whitespaces in make-file-arrays.py,
and then remove make-css-file-arrays.pl (in another patch).

> Source/WebCore/make-file-arrays.py:30
> +# Usage: make-file-arrays.py [--condition=condition-string]
--out-h=<header-file-name> --out-cpp=<cpp-file-name> <input-file>...

Nit: [--condition=conditional-flag-name] might be descriptive.

> Source/WebCore/make-file-arrays.py:39
> +    result = re.match(r"(\w+)\.(\w+)", os.path.basename(file_name))

r"([\w\d_]+)\.([\w\d_]+))" might be better?

More information about the webkit-reviews mailing list