[webkit-reviews] review requested: [Bug 19688] Add autodetection of image orientation from EXIF information : [Attachment 135273] preliminary patch, respecting orientation for ImageDocuments, with a setting to enable for all images

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has asked  for review:
Bug 19688: Add autodetection of image orientation from EXIF information
https://bugs.webkit.org/show_bug.cgi?id=19688

Attachment 135273: preliminary patch, respecting orientation for
ImageDocuments, with a setting to enable for all images
https://bugs.webkit.org/attachment.cgi?id=135273&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
Two issues:

1. I don't think it's legitimate to set shouldRespectImageOrientation on a
BitmapImage; my understanding is that that BitmapImage (via the image cache)
could be shared between page groups with differing settings. However, my patch
to plumb the setting through from all call sites and not require that had
ballooned up to 350K or so, and I wasn't really OK with the mess it was making
of Image/GraphicsContext/friends. Any ideas?

2. The drag images (as Eric noted) are drawn with the right size but the wrong
rotation (because the rotation happens via a transform on the context, which
certainly won't happen in the drag image case); this isn't OK either, though
that might be better as a followup fix.