[webkit-reviews] review granted: [Bug 82958] Web Inspector: CodeGeneratorInspector.py: switch Inspector, Memory and Database domains to typed API : [Attachment 135208] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 82958: Web Inspector: CodeGeneratorInspector.py: switch Inspector, Memory
and Database domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=82958

Attachment 135208: Patch
https://bugs.webkit.org/attachment.cgi?id=135208&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135208&action=review


> Source/WebCore/inspector/InspectorDatabaseResource.cpp:62
> +	   // FIXME: here we use string type according to Inspector.json.

Please file a bug on this and put its number next to FIXME.

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:205
> +    PassRefPtr<TypeBuilder::Array<TypeBuilder::Memory::DOMGroup> >
domGroups() { return m_domGroups; }

Why did it become PassRefPtr?