[webkit-reviews] review requested: [Bug 74680] [Plugins GTK/QT] Signed to Unsigned Conversion Error : [Attachment 135250] Signed to Unsigned Conversion Error

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 18:08:14 PDT 2012

Kwangmin Bang <justine.bang at samsung.com> has asked  for review:
Bug 74680: [Plugins GTK/QT] Signed to Unsigned Conversion Error

Attachment 135250: Signed to Unsigned Conversion Error

------- Additional Comments from Kwangmin Bang <justine.bang at samsung.com>
rebase the patch.

When tested webkit for desktop, it's not need this patch.
My testing environment is using floating viewport for mobile browser( view is
bigger than device screen).
For getting m_windowRect, I'm using contentsToScreen instead of
so, m_windowRect.x or y can be the negative.

However, I think these codes are a basic problem about conversion. ( unsigned =
signed )
this patch will prevent "Signed to Unsigned Conversion Error" and remove the
warning in build time.

How do you think about my opinion ?

More information about the webkit-reviews mailing list