[webkit-reviews] review granted: [Bug 82196] Revert RenderTheme paint and layout functions to ints : [Attachment 135088] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 82196: Revert RenderTheme paint and layout functions to ints
https://bugs.webkit.org/show_bug.cgi?id=82196

Attachment 135088: Patch
https://bugs.webkit.org/attachment.cgi?id=135088&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135088&action=review


> Source/WebCore/ChangeLog:15
> +	   Some platforms, such as Mac, use sub-pixel units for layout and
rendering, but it's still not
> +	   desirable to pass sub-pixel values to these API's, because
ultimately we'll render these objects
> +	   at whole-pixel values to avoid anti-aliasing.

I like your explanation, thanks for digging this.

> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:292
> +    IntRect
cancelButtonRect(cancelButtonObject->offsetFromAncestorContainer(inputRenderBox
).width(),
> +	   inputContentBox.y() + (inputContentBox.height() - cancelButtonSize +
1) / 2,
> +	   cancelButtonSize, cancelButtonSize);

I prefer when the arguments on the non-first row are aligned with the argument
on the line above but our style guide is silent on that so it's up to you.

> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:335
> +    IntRect
magnifierRect(magnifierObject->offsetFromAncestorContainer(inputRenderBox).widt
h(),
> +	   inputContentBox.y() + (inputContentBox.height() - magnifierSize + 1)
/ 2,
> +	   magnifierSize, magnifierSize);

Ditto.

> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:368
> +    IntRect
magnifierRect(magnifierObject->offsetFromAncestorContainer(inputRenderBox).widt
h(),
> +	   inputContentBox.y() + (inputContentBox.height() - magnifierHeight +
1) / 2,
> +	   magnifierWidth, magnifierHeight);

Ditto.