[webkit-reviews] review granted: [Bug 82962] run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set : [Attachment 135216] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 82962: run-webkit-tests with a relative --root causes tests to fail because
DYLD_LIBRARY_PATH is not set
https://bugs.webkit.org/show_bug.cgi?id=82962

Attachment 135216: Patch
https://bugs.webkit.org/attachment.cgi?id=135216&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135216&action=review


> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:378
> +	   return self._filesystem.join(os.getcwd(), build_directory, *comps)

This is fine but I'd probably do:

return self._filesystem.join(self.abspath(build_directory), *comps)

instead; that captures the intent a little more clearly (IMO, of course).