[webkit-reviews] review requested: [Bug 82660] Frequent crashes in JSC::parse in a worker thread when running regression tests : [Attachment 135202] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 15:07:15 PDT 2012


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 82660: Frequent crashes in JSC::parse in a worker thread when running
regression tests
https://bugs.webkit.org/show_bug.cgi?id=82660

Attachment 135202: Updated patch
https://bugs.webkit.org/attachment.cgi?id=135202&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
It turns out that isEmpty() works because it was checking both Null and empty. 
The issue we have here is the Null case.  This patch uses a Null check in the
caller to WorkerScriptController::evaluate() instead of having the isEmpty()
check there.


More information about the webkit-reviews mailing list