[webkit-reviews] review denied: [Bug 81854] RadioNodeList support in HTMLFormElement::elements : [Attachment 135095] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 12:44:30 PDT 2012


Darin Adler <darin at apple.com> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 81854: RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854

Attachment 135095: Updated patch
https://bugs.webkit.org/attachment.cgi?id=135095&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Ryosuke is right. This design where we get and re-sort the list each time is
going to be pathologically slow given how expensive the compareTreeOrder
function is. This needs to be redone in a different want that gets the elements
in tree order in the first place.


More information about the webkit-reviews mailing list