[webkit-reviews] review granted: [Bug 82760] WebViewImpl doesn't notify the page that the user has canceled fullscreen. : [Attachment 134973] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Bill Budge
<bbudge at gmail.com>'s request for review:
Bug 82760: WebViewImpl doesn't notify the page that the user has canceled
fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=82760

Attachment 134973: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=134973&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134973&action=review


> Source/WebKit/chromium/src/WebViewImpl.cpp:1327
> +	       doc->webkitCancelFullScreen();

if exiting fullscreen is initiated by JS calling
document.webkitCancelFullScreen(),
then we will eventually reach this code again.	it looks like the second call
to
webkitCancelFullScreen() will call webkitExitFullscreen().  in this case, do we

have to worry about a second webkitfullscreenchange event being generated?  it
looks like Document::addDocumentToFullScreenChangeEventQueue() could be called
more than once.