[webkit-reviews] review granted: [Bug 82686] [chromium] Add layout test for a video that changes dimensions while decoding : [Attachment 134717] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Andrew Scherkus
<scherkus at chromium.org>'s request for review:
Bug 82686: [chromium] Add layout test for a video that changes dimensions while
decoding
https://bugs.webkit.org/show_bug.cgi?id=82686

Attachment 134717: Patch
https://bugs.webkit.org/attachment.cgi?id=134717&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134717&action=review


> LayoutTests/platform/chromium/media/video-frame-size-change.html:19
> +		   waitForEvent("canplay", function() {
> +		       testExpected(video.clientWidth, 1920);
> +		       testExpected(video.clientHeight, 1080);
> +		       testExpected(video.videoWidth, 1920);
> +		       testExpected(video.videoHeight, 1080);
> +		       video.play();
> +		   });

It is probably worth having another <video> element with "width" and "height"
attributes to make sure that .clientWidth and .clientHeight do NOT change when
the intrinsic size changes.

> LayoutTests/platform/chromium/media/video-frame-size-change.html:34
> +		       // Note that it's not specified whether we should scale
the new frame size
> +		       // or adjust the size of the element. See the following
for details:
> +		       //
http://code.google.com/p/chromium/issues/detail?id=117629
> +		       //

I don't think this is necessary.