[webkit-reviews] review canceled: [Bug 78193] Inserting a paragraph between quoted lines in editing/deleting/delete-4038408-fix.html doesn't work : [Attachment 134857] First try

[bugzilla-daemon at webkit.org]

yi shen <yi.4.shen at nokia.com> has canceled yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 78193: Inserting a paragraph between quoted lines in
editing/deleting/delete-4038408-fix.html doesn't work
https://bugs.webkit.org/show_bug.cgi?id=78193

Attachment 134857: First try
https://bugs.webkit.org/attachment.cgi?id=134857&action=review

------- Additional Comments from yi shen <yi.4.shen at nokia.com>
In order to adjust position in ReplaceSelectionCommand and make it accessible
by InsertParagraphSeparatorCommand, we have to call setEndingSelection() in
ReplaceSelectionCommand, then InsertParagraphSeparatorCommand can retrieve the
new position by calling the endingSelection(). However,  the position we pass
to setEndingSelection() would be canonicalize, so the insertion position that
can be seen by InsertParagraphSeparatorCommand may NOT be the desired one. 

For example,  we try to ask InsertParagraphSeparatorCommand to insert a
paragraph separator in [Div, 1],    <div><blockquote>abc</blockquote>^<div>,
after calling the setEndingSelection(), the insertion position changed to
[Text, 3],  <div><blockquote>abc^</blockquote><div>. AS a result, the paragraph
separator is insert into a unexpected place.

As a workaround, the new patch still use an extra parameter to provide the
missing information for the InsertParagraphSeparatorCommand. Let me know if you
have better idea to do it. Thanks!