[webkit-reviews] review granted: [Bug 72852] Scroll position is lost after hide/show element : [Attachment 134793] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 2 10:17:45 PDT 2012
Julien Chaffraix <jchaffraix at webkit.org> has granted Rakesh
<rakesh.kn at motorola.com>'s request for review:
Bug 72852: Scroll position is lost after hide/show element
https://bugs.webkit.org/show_bug.cgi?id=72852
Attachment 134793: Updated patch
https://bugs.webkit.org/attachment.cgi?id=134793&action=review
------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134793&action=review
I will fix the ChangeLog this time as it will be faster.
> Source/WebCore/ChangeLog:8
> + RenderLayer is destroyed, which can be used to restore the scroll
position if the same element is
> + again added to the render tree.
That's not exact: a RenderObject can lose its RenderLayer without being removed
from the tree. The example is toggling overflow: hidden to overflow: visible
(as in your test).
> Source/WebCore/ChangeLog:10
> + Webkit behaviour will be same as Firefox and IE. It differs from
Opera in a way that Opera does
Web*K*it.
> Source/WebCore/ChangeLog:34
> + Storing the scroll offset if document is not being destroyed.
Normally we want the ChangeLog to be consistent. So here it should be:
Store the scroll offset if *the* document is not being destroyed.
More information about the webkit-reviews
mailing list