[webkit-reviews] review denied: [Bug 81588] Array.prototype.toString should be generic : [Attachment 135074] Patch

[bugzilla-daemon at webkit.org]

Erik Arvidsson <arv at chromium.org> has denied hojong.han at samsung.com's request
for review:
Bug 81588: Array.prototype.toString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588

Attachment 135074: Patch
https://bugs.webkit.org/attachment.cgi?id=135074&action=review

------- Additional Comments from Erik Arvidsson <arv at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135074&action=review


> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:270
> +		   return JSValue::encode(jsMakeNontrivialString(exec, "[object
", thisObject->methodTable()->className(thisObject), "]"));

This does not seem right. You should call the original
Object.prototype.toString instead of duplicating its implementation.


...and add tests