[webkit-reviews] review granted: [Bug 82143] [Chromium] Add WebKit API for WebCore::TextFieldDecorator : [Attachment 135025] Patch 3

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 82143: [Chromium] Add WebKit API for WebCore::TextFieldDecorator
https://bugs.webkit.org/show_bug.cgi?id=82143

Attachment 135025: Patch 3
https://bugs.webkit.org/attachment.cgi?id=135025&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135025&action=review


> Source/WebKit/chromium/src/WebViewImpl.h:595
> +    Vector<OwnPtr<WebCore::TextFieldDecorator> > m_textFieldDecorators;

I wonder if we could put some sort of an assertion for going over a certain
number of decorators. Here's my concern: over time, the consumers of this API
may find it useful and start adding more decorators -- and unexpectedly see
performance degradation due to NxM complexity of the plumbing. Perhaps if we
somehow alerted future us that things are going awry, we would be less
surprised about its effects.