[webkit-reviews] review granted: [Bug 78706] Renaming parameters for positioning a track cue : [Attachment 129568] Proposed patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Eric Carlson <eric.carlson at apple.com>'s
request for review:
Bug 78706: Renaming parameters for positioning a track cue
https://bugs.webkit.org/show_bug.cgi?id=78706

Attachment 129568: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=129568&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129568&action=review


> Source/WebCore/html/track/TextTrackCue.cpp:401
> +TextTrackCue::CueSetting TextTrackCue::settingName(const String& name)
> +{
> +    DEFINE_STATIC_LOCAL(const String, verticalKeyword, ("vertical"));
> +    DEFINE_STATIC_LOCAL(const String, lineKeyword, ("line"));
> +    DEFINE_STATIC_LOCAL(const String, positionKeyword, ("position"));
> +    DEFINE_STATIC_LOCAL(const String, sizeKeyword, ("size"));
> +    DEFINE_STATIC_LOCAL(const String, alignKeyword, ("align"));
> +
> +    if (name == verticalKeyword)
> +	   return Vertical;
> +    else if (name == lineKeyword)
> +	   return Line;
> +    else if (name == positionKeyword)
> +	   return Position;
> +    else if (name == sizeKeyword)
> +	   return Size;
> +    else if (name == alignKeyword)
> +	   return Align;
> +
> +    return None;
> +}

Is this common enough that we should consider using AtomicString?