[webkit-reviews] review requested: [Bug 82728] Split remaining CSSRules into internal and CSSOM types : [Attachment 135091] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 07:54:40 PDT 2012

Alexis Menard (darktears) <alexis.menard at openbossa.org> has asked  for review:
Bug 82728: Split remaining CSSRules into internal and CSSOM types

Attachment 135091: patch

------- Additional Comments from Alexis Menard (darktears)
<alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135091&action=review

> Source/WebCore/css/CSSStyleSheet.cpp:95
> +    , m_cssParserMode(ownerRule ?
ownerRule->parentStyleSheet()->cssParserMode() : CSSStrictMode)

Is this always a safe call? StyleRuleImport constructor always take a
stylesheet as a parameter but clearParentStyleSheet is called in various
places. Is there a scenario where the importRule will not have a

> Source/WebCore/css/CSSStyleSheet.cpp:175
> +	       m_childRuleCSSOMWrappers[i]->setParentStyleSheet(0);

Seems like the indentation is wrong.

More information about the webkit-reviews mailing list