[webkit-reviews] review granted: [Bug 82891] Web Inspector: Implement frontend for device metrics emulation : [Attachment 135092] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 82891: Web Inspector: Implement frontend for device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82891

Attachment 135092: Patch
https://bugs.webkit.org/attachment.cgi?id=135092&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135092&action=review


> Source/WebCore/ChangeLog:48
> +2012-04-02  Alexander Pavlov  <apavlov at chromium.org>

Please remove this.

> Source/WebCore/inspector/front-end/SettingsScreen.js:433
> +	       if (metrics && metrics.isValid && metrics.width &&
metrics.height)

You are using isValid as a getter, while it is a function. Side-note: could you
annotate device metrics class?

> Source/WebCore/inspector/front-end/UserAgentSupport.js:57
> +WebInspector.UserAgentSupport.DeviceMetrics.parseFromSettings =
function(value)

parseSetting

> Source/WebCore/inspector/front-end/UserAgentSupport.js:70
> +WebInspector.UserAgentSupport.DeviceMetrics.parseFromUserInput =
function(widthString, heightString, fontScaleFactorString)

parseUserInput