[webkit-reviews] review denied: [Bug 73093] InspectorServer: Add a Generic WebSocket Server. : [Attachment 134621] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 05:24:36 PDT 2012

Simon Hausmann <hausmann at webkit.org> has denied Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 73093: InspectorServer: Add a Generic WebSocket Server.

Attachment 134621: Patch

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134621&action=review

Only nitpicks from my side, after Kenneth's review. Let's do another round :)

>> Source/WebKit2/ChangeLog:10
>> +	    that handles passes on what it doesn't know on to its Client for
> client*

and remove "handles", so the sentence just reads "... server that passes on
what it doesn't know ..."

> Source/WebCore/platform/network/qt/SocketStreamHandleQt.cpp:90
> +#ifndef QT_NO_OPENSSL

It's not exactly related to your patch, but I don't think we should disable the
websocket feature altogether if Qt comes without SSL support. So I don't think
we need the #ifdef here :)

> Source/WebKit2/UIProcess/InspectorServer/WebSocketServerConnection.cpp:111
> +    CString header = builder.toString().latin1();

I hope this is as efficient as we want it to be ;)

More information about the webkit-reviews mailing list