[webkit-reviews] review granted: [Bug 82827] Web Inspector: Implement backend for device metrics emulation : [Attachment 134952] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 82827: Web Inspector: Implement backend for device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82827

Attachment 134952: Patch
https://bugs.webkit.org/attachment.cgi?id=134952&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134952&action=review


> Source/WebCore/inspector/Inspector.json:314
> +		   "description": "Checks whether
<code>setDeviceMetricsOverride()</code> can be invoked.",

drop the ()

> Source/WebCore/inspector/Inspector.json:316
> +		       { "name": "result", "type": "boolean", "description":
"If true, <code>setDeviceMetricsOverride()</code> can safely be invoked on the
agent." }

ditto

> Source/WebCore/inspector/Inspector.json:317
> +		   ]

should be hidden

> Source/WebCore/inspector/InspectorClient.h:60
> +    virtual void overrideDeviceMetrics(int /*width*/, int /*height*/, float
/*fontScaleFactor*/) { }

Please file a bug requesting this feature is either upstreamed to WebCore or
implemented for the other ports.

> Source/WebCore/inspector/InspectorClient.h:61
> +    virtual void autoZoomPageToFitWidth() { }

Can we implement it in WebCore?