[webkit-reviews] review granted: [Bug 82847] Add mechanism for mapping from StyleRules back to fully constructed CSSStyleRules : [Attachment 135013] with bug url

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 82847: Add mechanism for mapping from StyleRules back to fully constructed
CSSStyleRules
https://bugs.webkit.org/show_bug.cgi?id=82847

Attachment 135013: with bug url
https://bugs.webkit.org/attachment.cgi?id=135013&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135013&action=review


r=me. Let's do this thing.

> Source/WebCore/css/CSSStyleSelector.cpp:2905
> +    const Vector<RefPtr<StyleSheet> >& styleSheets =
document->styleSheets()->vector();
> +    for (unsigned i = 0; i < styleSheets.size(); ++i) {

You could use the iteration helpers of StyleSheetList directly here instead of
grabbing the Vector. NABD.

> Source/WebCore/css/CSSStyleSelector.h:247
> +    CSSStyleRule* ensureFullCSSOMWrapperForStyleRule(StyleRule*);

As you mentioned, this could do with a scarier name, e.g
ensureFullCSSOMWrapperForInspectorWhileUsingTerabytesOfMemory().