[webkit-reviews] review denied: [Bug 82871] Disable ENABLE_DATALIST for now : [Attachment 135057] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 03:23:37 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 82871: Disable ENABLE_DATALIST for now
https://bugs.webkit.org/show_bug.cgi?id=82871

Attachment 135057: Patch
https://bugs.webkit.org/attachment.cgi?id=135057&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135057&action=review


You need to touch LayoutTests/platform/chromium/test_expectations.txt too.

> WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:82
>		Value="ENABLE_DATALIST"
> -		PerformEnvironmentSet="true"
> +		PerformEnvironmentSet="false"

Do not change PerformEnvironentSet.  What you need to do is to make Value
empty.


More information about the webkit-reviews mailing list