[webkit-reviews] review denied: [Bug 82871] Disable ENABLE_DATALIST for now : [Attachment 135051] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 02:58:20 PDT 2012

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 82871: Disable ENABLE_DATALIST for now

Attachment 135051: Patch

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135051&action=review

You need to update Source/*/Configuration/FeatureDefines.xcconfig,
WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops, and

> Tools/Scripts/build-webkit:190
> +	 define => "ENABLE_DATALIST", default => isBlackBerry(), value =>
\$datalistSupport },

I'm not sure if Blackberry uses this script.

> LayoutTests/fast/forms/datalist/datalist-nonoption-child.html:4
> +<script src="../../fast/js/resources/js-test-pre.js"></script>

../../js/resource/js-test-pre.js ?

More information about the webkit-reviews mailing list